pengxiangyu commented on code in PR #12730:
URL: https://github.com/apache/doris/pull/12730#discussion_r975034468
##########
be/src/runtime/file_result_writer.h:
##########
@@ -42,8 +42,15 @@ struct ResultFileOptions {
std::vector<TNetworkAddress> broker_addresses;
std::map<std::string, std::string> broker_properties;
std::string success_file_name = "";
- std::vector<std::vector<std::string>> schema;
- std::map<std::string, std::string> file_properties;
+ std::vector<std::vector<std::string>> schema; //not use in outfile
with parquet format
+ std::map<std::string, std::string> file_properties; //not use in outfile
with parquet format
+
+ std::vector<TParquetRepetitionType::type> schemas_repetition_type;
+ std::vector<TParquetDataType::type> schemas_data_type;
+ std::vector<std::string> schemas_column_name;
Review Comment:
Why don't create a struct instead of schemas_repetition_type
schemas_data_type schemas_column_name
such as:
TParquetSchema {
TParquetRepetitionType::type repetition_type;
TParquetDataType::type data_type;
std::string column_name;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
