HappenLee commented on code in PR #12970:
URL: https://github.com/apache/doris/pull/12970#discussion_r981044071
##########
be/src/vec/runtime/vparquet_writer.cpp:
##########
@@ -215,58 +225,64 @@ Status VParquetWriterWrapper::write(const Block& block) {
parquet::RowGroupWriter* rgWriter = get_rg_writer();
parquet::Int32Writer* col_writer =
static_cast<parquet::Int32Writer*>(rgWriter->column(i));
- int32_t default_int32 = 0;
if (null_map != nullptr) {
+ auto& null_data = assert_cast<const
ColumnUInt8&>(*null_map).get_data();
if (const auto* nested_column =
check_and_get_column<const
ColumnVector<Int32>>(col)) {
for (size_t row_id = 0; row_id < sz; row_id++) {
Review Comment:
`def_level[row_id] = (bool) null_data[row_id] == 0` may SIMD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
