weizhengte commented on code in PR #12987:
URL: https://github.com/apache/doris/pull/12987#discussion_r984304410
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java:
##########
@@ -54,7 +51,7 @@
* For example:
* "@ndv = 10" means that the number distinct values is 10 in the whole table.
*/
-public class ColumnStats {
+public class ColumnStat {
Review Comment:
I feel this is not necessary, we'd better try to keep it consistent with
other databases.`stat` feels more like the meaning of status, `stats` means
statistical information,
And `ColumnStats` is used to describe the statistics of the original table
column.
For the problem of naming the collection of nereids, the columnStats of the
collection type uses `columnsStats`,
Instead of `columnStatss`, does this also work? Of course, I think these can
be discussed further.
I roughly looked at the overall code, and I found that the Stats-Derivation
module may only temporarily support `Double` type statistics, so you changed
the type of columnStats to
`Double` type.
What I understand is that Statistics is used to describe the statistical
information of the original table, and Stats-Derivation is used to derive
statistics after each operator. They actually belong to two independent
module. Stats-Derivation obtains the statistics of the original table from
Statistics, and should not modify the statistics of the original table. The
original statistics can only be modified by specific tasks or statements.
So, should the type support of Stats-Derivation be adapted in the Stats
Derivation module? In addition, this means that the previously designed and
implemented column statistics need to be reimplemented one by one from the
`Double` type. I think this is unreasonable, for example, users can view other
types of statistics, and because this change only allows viewing of `Double`
type stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
