yiguolei commented on code in PR #13522:
URL: https://github.com/apache/doris/pull/13522#discussion_r1001583168
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1026,38 +1026,8 @@ void StorageEngine::notify_listeners() {
}
Status StorageEngine::execute_task(EngineTask* task) {
- auto lock_related_tablets = [&]() ->
std::vector<std::unique_lock<std::shared_mutex>> {
- // add write lock to all related tablets
Review Comment:
task execute will modify tablet's meta, so that I think we should acquire
lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
