adonis0147 commented on code in PR #13607:
URL: https://github.com/apache/doris/pull/13607#discussion_r1003389550


##########
thirdparty/build-thirdparty.sh:
##########
@@ -1345,8 +1345,13 @@ build_hdfs3() {
     cd "${BUILD_DIR}"
     rm -rf ./*
 
+    if [[ "$(uname -m)" == "aarch64" ]]; then
+        SSE_OPTION='-DENABLE_SSE=OFF'
+    else
+        SSE_OPTION='-DENABLE_SSE=ON'
+    fi

Review Comment:
   ```suggestion
       if [[ "$(uname -m)" != 'x86_64' ]]; then
           SSE_OPTION='ON'
       else
           SSE_OPTION='OFF'
       fi
   ```
   
   It is better to use `x86_64` to compare to the result due to the result of 
`uname -m` is `arm64` on macOS M1.
   
   BTW, it seems that the compiler just complains the unrecognized option and 
continues. The error doesn't interrupt the compilation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to