dataroaring commented on code in PR #13359:
URL: https://github.com/apache/doris/pull/13359#discussion_r1009127913
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -36,7 +36,16 @@ BetaRowsetReader::BetaRowsetReader(BetaRowsetSharedPtr
rowset)
_rowset->acquire();
}
-Status BetaRowsetReader::init(RowsetReaderContext* read_context) {
+void BetaRowsetReader::reset_read_options() {
+ _read_options.delete_condition_predicates =
std::make_shared<AndBlockColumnPredicate>();
+ _read_options.column_predicates.clear();
+ _read_options.col_id_to_predicates.clear();
+ _read_options.col_id_to_del_predicates.clear();
+ _read_options.key_ranges.clear();
+}
+
+Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext*
read_context,
+ std::vector<RowwiseIterator*>*
out_iters) {
RETURN_NOT_OK(_rowset->load());
_context = read_context;
Review Comment:
This assignment is duplicated with init? BTW, get methods should not set
member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
