xinyiZzz commented on code in PR #13781:
URL: https://github.com/apache/doris/pull/13781#discussion_r1009135808
##########
be/src/service/doris_main.cpp:
##########
@@ -321,22 +321,6 @@ int main(int argc, char** argv) {
return -1;
}
-#if !defined(__SANITIZE_ADDRESS__) && !defined(ADDRESS_SANITIZER) &&
!defined(LEAK_SANITIZER) && \
- !defined(THREAD_SANITIZER) && !defined(USE_JEMALLOC)
- // Aggressive decommit is required so that unused pages in the TCMalloc
page heap are
- // not backed by physical pages and do not contribute towards memory
consumption.
- if (doris::config::tc_enable_aggressive_memory_decommit) {
-
MallocExtension::instance()->SetNumericProperty("tcmalloc.aggressive_memory_decommit",
1);
- }
- // Change the total TCMalloc thread cache size if necessary.
- if (!MallocExtension::instance()->SetNumericProperty(
- "tcmalloc.max_total_thread_cache_bytes",
- doris::config::tc_max_total_thread_cache_bytes)) {
- fprintf(stderr, "Failed to change TCMalloc total thread cache
size.\n");
Review Comment:
What is the reason for removing `tcmalloc.aggressive_memory_decommit` and
`tcmalloc.max_total_thread_cache_bytes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
