fieldzuo opened a new pull request, #59190:
URL: https://github.com/apache/doris/pull/59190
Problem:
TabletStatMgr.runAfterCatalogReady() throws ConcurrentModificationException
when iterating over dbIds and table lists while they are being modified by
other threads concurrently.
Root Cause:
1. Line 132: Direct iteration over dbIds returned from getDbIds()
2. Line 137: Direct iteration over tables returned from getTables()
3. Line 164: Direct iteration over partitions from getAllPartitions()
These collections can be modified by other threads during iteration, causing
ConcurrentModificationException.
Solution:
Create immutable snapshots of the collections using stream().collect()
before iteration to avoid concurrent modification issues.
Changes:
- Create snapshot of dbIds before iteration
- Create snapshot of tableList for each database
- Create snapshot of allPartitions for each table
- Add comments explaining the fix
This ensures thread-safe iteration without requiring additional locks.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
