jackwener commented on code in PR #14051:
URL: https://github.com/apache/doris/pull/14051#discussion_r1017983205
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -318,4 +319,11 @@ public static void addSlotsUsedByOn(Set<Slot> usedSlots,
List<NamedExpression> p
}
});
}
+
+ public static Set<Slot> getJoinOutput(Plan left, Plan right) {
+ HashSet<Slot> joinOutput = new HashSet<>();
+ joinOutput.addAll(left.getOutput());
+ joinOutput.addAll(right.getOutput());
Review Comment:
getOutputSet include `copy()`, which means more overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
