luozenglin commented on code in PR #14155:
URL: https://github.com/apache/doris/pull/14155#discussion_r1019786535
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -85,7 +84,7 @@ Status VScanNode::prepare(RuntimeState* state) {
Status VScanNode::open(RuntimeState* state) {
_input_tuple_desc =
state->desc_tbl().get_tuple_descriptor(_input_tuple_id);
_output_tuple_desc =
state->desc_tbl().get_tuple_descriptor(_output_tuple_id);
- START_AND_SCOPE_SPAN_IF(state->enable_profile(), state->get_tracer(),
"VScanNode::open");
+ START_AND_SCOPE_SPAN(state->get_tracer(), span, "VScanNode::open");
Review Comment:
The current tracing has a separate switch `enable_tracing`, which I think
should be consistent in the scan node with the other nodes. If the tracing
switch needs to be replaced with a profile switch, the replacement should be
done later in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
