gavinchou commented on code in PR #60520:
URL: https://github.com/apache/doris/pull/60520#discussion_r2766938420
##########
cloud/src/recycler/recycler_operation_log.cpp:
##########
@@ -672,6 +684,53 @@ int InstanceRecycler::recycle_operation_logs() {
size_t recycled_operation_log_data_size = 0;
DORIS_CLOUD_DEFER {
+ metrics_context.finish_report();
+
+ if (stats_enabled) {
Review Comment:
what is the cost to stats all the stats except
`scan_and_statistics_operation_logs()` ?
`scan_and_statistics_operation_logs()` may scan lots of KVs, it may be
turned off on demand, however, the rest stats seems light-weighted, it seems no
harm to collect the stats by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
