Copilot commented on code in PR #60573:
URL: https://github.com/apache/doris/pull/60573#discussion_r2773011640
##########
regression-test/suites/load_p0/stream_load/test_group_commit_redirect.groovy:
##########
@@ -166,7 +166,7 @@ suite('test_group_commit_redirect', 'docker') {
location = getRedirectLocation(feIp, fePort, "", "async_mode")
log.info("default location: ${location}")
-
assertTrue(location.contains("11.20.20.19:8040/api/$databaseName/$tableName/_stream_load_forward?")
&& (location.contains("forward_to=${be1Ip}:${be1HttpPort}") ||
location.contains("forward_to=${be2Ip}:${be2HttpPort}") ||
location.contains("forward_to=${be3Ip}:${be3HttpPort}")))
+
assertTrue(location.contains("$feIp:8040/api/$databaseName/$tableName/_stream_load_forward?")
&& (location.contains("forward_to=${be1Ip}:${be1HttpPort}") ||
location.contains("forward_to=${be2Ip}:${be2HttpPort}") ||
location.contains("forward_to=${be3Ip}:${be3HttpPort}")))
Review Comment:
Port 8040 is hardcoded in the default redirect policy assertion. Consider
whether this port should be derived from a variable (like fePort) or a
configuration constant. If 8040 is a specific port required for the group
commit forward functionality when using the default redirect policy, this
should be documented or made configurable to avoid potential issues if the port
changes.
##########
regression-test/suites/load_p0/stream_load/test_group_commit_redirect.groovy:
##########
@@ -178,7 +178,7 @@ suite('test_group_commit_redirect', 'docker') {
location = getRedirectLocation(feIp, fePort, "", "off_mode")
log.info("public location: ${location}")
-
assertTrue(location.contains("11.20.20.19:8040/api/$databaseName/$tableName/_stream_load"))
+
assertTrue(location.contains("$feIp:8040/api/$databaseName/$tableName/_stream_load"))
Review Comment:
Port 8040 is hardcoded in the default redirect policy assertion. Consider
whether this port should be derived from a variable (like fePort) or a
configuration constant. If 8040 is a specific port required for the group
commit forward functionality when using the default redirect policy, this
should be documented or made configurable to avoid potential issues if the port
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
