yiguolei commented on code in PR #60559:
URL: https://github.com/apache/doris/pull/60559#discussion_r2777480335
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicyMgr.java:
##########
@@ -244,27 +245,36 @@ public void createWorkloadSchedPolicy(String policyName,
boolean isIfNotExists,
}
}
- private boolean checkPolicyCondition(List<WorkloadCondition>
conditionList) throws UserException {
+ private Boolean checkPolicyCondition(List<WorkloadCondition>
conditionList) throws UserException {
if (conditionList.size() >
Config.workload_max_condition_num_in_policy) {
throw new UserException(
"condition num in a policy can not exceed " +
Config.workload_max_condition_num_in_policy);
}
- boolean containsFeMetric = false;
- boolean containsBeMetric = false;
+ boolean hasFeOnlyMetric = false;
+ boolean hasBeOnlyMetric = false;
for (WorkloadCondition cond : conditionList) {
- if (FE_METRIC_SET.contains(cond.getMetricType())) {
- containsFeMetric = true;
- }
- if (BE_METRIC_SET.contains(cond.getMetricType())) {
- containsBeMetric = true;
+ boolean isFe = FE_METRIC_SET.contains(cond.getMetricType());
Review Comment:
这里是为了改啥？
##########
be/src/pipeline/pipeline_fragment_context.h:
##########
@@ -95,6 +95,8 @@ class PipelineFragmentContext : public TaskExecutionContext {
[[nodiscard]] int get_fragment_id() const { return _fragment_id; }
+ RuntimeState* get_runtime_state() { return _runtime_state.get(); }
Review Comment:
这个方法有用？
##########
fe/fe-core/src/main/java/org/apache/doris/qe/runtime/ThriftPlansBuilder.java:
##########
@@ -402,6 +403,13 @@ private static TPipelineFragmentParams
fragmentToThriftIfAbsent(
params.setLocalParams(Lists.newArrayList());
params.setWorkloadGroups(coordinatorContext.getWorkloadGroups());
+ if (connectContext != null &&
connectContext.getCurrentUserIdentity() != null) {
Review Comment:
除了查询之外，streamload 以及insert into select 这里的设置也会起作用吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
