CalvinKirs opened a new pull request, #60636:
URL: https://github.com/apache/doris/pull/60636
…
## Proposed changes
Fix the issue where column binding fails for external tables (Hive, Iceberg,
etc.) when users reference table names with original case in SQL.
Problem
When querying external Hive tables, the following SQL fails: SELECT * FROM
TPCH50.DIM_LINEITEM_CORE_OD001_V1
WHERE DIM_LINEITEM_CORE_OD001_V1.dt = '20260108' LIMIT 10; -- Error: Unknown
column 'dt' in 'DIM_LINEITEM_CORE_OD001_V1' in FILTER clause But using an alias
works:
SELECT * FROM TPCH50.DIM_LINEITEM_CORE_OD001_V1 AS
DIM_LINEITEM_CORE_OD001_V1 WHERE DIM_LINEITEM_CORE_OD001_V1.dt = '20260108'
LIMIT 10; -- Success
Root Cause
1. Hive Metastore stores table names in lowercase (e.g.,
dim_lineitem_core_od001_v1)
2. The slot qualifier uses table.getName() which returns the lowercase HMS
table name
3. Users reference the table with original case in SQL (e.g.,
DIM_LINEITEM_CORE_OD001_V1.dt)
4. ExpressionAnalyzer.sameTableName() performs case-sensitive comparison
when lower_case_table_names != 1, causing binding to fail Solution
Change sameTableName() to always use case-insensitive comparison for table
names. This is consistent with:
- Catalog name comparison (already case-insensitive at line 1079)
- Database name comparison (already case-insensitive at line 1092)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]