morningman commented on code in PR #60540:
URL: https://github.com/apache/doris/pull/60540#discussion_r2783182137
##########
be/src/vec/common/sort/sorter.h:
##########
@@ -202,15 +202,17 @@ class FullSorter final : public Sorter {
_max_buffered_block_bytes = max_buffered_block_bytes;
}
+ auto merge_sort_state() { return _state.get(); }
+
+ Status _do_sort();
Review Comment:
```suggestion
Status do_sort();
```
##########
be/src/vec/sink/writer/iceberg/viceberg_partition_writer.cpp:
##########
@@ -142,6 +147,17 @@ TIcebergCommitData
VIcebergPartitionWriter::_build_iceberg_commit_data() {
iceberg_commit_data.__set_file_size(_file_format_transformer->written_len());
iceberg_commit_data.__set_file_content(TFileContent::DATA);
iceberg_commit_data.__set_partition_values(_partition_values);
+ if (_file_format_type == TFileFormatType::FORMAT_PARQUET) {
+ TIcebergColumnStats column_stats;
+ auto st =
static_cast<VParquetTransformer*>(_file_format_transformer.get())
Review Comment:
Do we need to check this `st`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
