Copilot commented on code in PR #3364: URL: https://github.com/apache/doris-website/pull/3364#discussion_r2789478839
########## versioned_docs/version-2.1/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -206,7 +206,7 @@ Similarly, replica balancing ensures that a copy of the same table will not be d We use Cluster LoadStatistics (CLS) to represent the load balancing of each backend in a cluster. Tablet Scheduler triggers cluster equilibrium based on this statistic. We currently calculate a load Score for each BE as the BE load score by using **disk usage** and **number of copies**. The higher the score, the heavier the load on the BE. -Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. Among them, capacityCoefficient will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the capacityCoefficient value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: +Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. If a valid `backend_load_capacity_coeficient` parameter is configured (value range `0.0`~`1.0`), then `capacityCoefficient = backend_load_capacity_coeficient`. Otherwise, `capacityCoefficient` will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the `capacityCoefficient` value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: `capacityCoefficient = 2 * Disk Utilization - 0.5` Review Comment: The doc introduces `backend_load_capacity_coeficient` but this config key is not referenced anywhere else in the docs (including the FE config reference), so readers can’t easily discover where/how to set it or verify the exact spelling. Consider explicitly calling it an FE config item and adding a link (or a short note) to the configuration reference. Also, since you state the coefficients “sum is constant to 1”, it would help to explicitly state how `replicaNumCoefficient` is derived when `capacityCoefficient` is fixed (e.g., `replicaNumCoefficient = 1 - capacityCoefficient`). ########## i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -210,7 +210,7 @@ Doris 会自动进行集群内的副本均衡。目前支持两种均衡策略 我们用 ClusterLoadStatistics（CLS）表示一个 cluster 中各个 Backend 的负载均衡情况。TabletScheduler 根据这个统计值，来触发集群均衡。我们当前通过 **磁盘使用率** 和 **副本数量** 两个指标，为每个 BE 计算一个 loadScore，作为 BE 的负载分数。分数越高，表示该 BE 的负载越重。 -磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。其中 capacityCoefficient 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 capacityCoefficient 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： +磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。如果系统配置了有效的 `backend_load_capacity_coeficient` 参数（取值范围 `0.0`~`1.0`），则 `capacityCoefficient = backend_load_capacity_coeficient`。否则，`capacityCoefficient` 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 `capacityCoefficient` 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： `capacityCoefficient= 2 * 磁盘使用率 - 0.5` Review Comment: 这里新增了 `backend_load_capacity_coeficient` 的说明，但该配置项在文档中几乎没有其他引用（包括 FE 配置项参考文档），读者不容易确认具体在哪配置以及该 key 的拼写是否准确。建议明确说明这是 FE 配置项并补充到配置参考或加上链接/提示。另外既然前文强调两个系数“和恒为 1”，当 `capacityCoefficient` 被固定时也建议明确 `replicaNumCoefficient` 的计算方式（例如 `replicaNumCoefficient = 1 - capacityCoefficient`），避免读者疑惑。 ```suggestion 磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。如果在 FE 配置文件中通过配置项 `backend_load_capacity_coefficient` 显式配置了有效参数（取值范围 `0.0`~`1.0`），则有 `capacityCoefficient = backend_load_capacity_coefficient`，同时 `replicaNumCoefficient = 1 - capacityCoefficient`。该配置项的详细说明可参考 FE 配置项参考文档。否则，`capacityCoefficient` 会根据实际磁盘使用率动态调整，`replicaNumCoefficient` 始终为 `1 - capacityCoefficient`。当一个 BE 的总体磁盘使用率在 50% 以下，则 `capacityCoefficient` 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： `capacityCoefficient = 2 * 磁盘使用率 - 0.5` ``` ########## i18n/zh-CN/docusaurus-plugin-content-docs/version-3.x/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -210,7 +210,7 @@ Doris 会自动进行集群内的副本均衡。目前支持两种均衡策略 我们用 ClusterLoadStatistics（CLS）表示一个 cluster 中各个 Backend 的负载均衡情况。TabletScheduler 根据这个统计值，来触发集群均衡。我们当前通过 **磁盘使用率** 和 **副本数量** 两个指标，为每个 BE 计算一个 loadScore，作为 BE 的负载分数。分数越高，表示该 BE 的负载越重。 -磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。其中 capacityCoefficient 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 capacityCoefficient 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： +磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。如果系统配置了有效的 `backend_load_capacity_coeficient` 参数（取值范围 `0.0`~`1.0`），则 `capacityCoefficient = backend_load_capacity_coeficient`。否则，`capacityCoefficient` 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 `capacityCoefficient` 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： `capacityCoefficient= 2 * 磁盘使用率 - 0.5` Review Comment: 这里新增了 `backend_load_capacity_coeficient` 的说明，但该配置项在文档中几乎没有其他引用（包括 FE 配置项参考文档），读者不容易确认具体在哪配置以及该 key 的拼写是否准确。建议明确说明这是 FE 配置项并补充到配置参考或加上链接/提示。另外既然前文强调两个系数“和恒为 1”，当 `capacityCoefficient` 被固定时也建议明确 `replicaNumCoefficient` 的计算方式（例如 `replicaNumCoefficient = 1 - capacityCoefficient`），避免读者疑惑。 ########## docs/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -206,7 +206,7 @@ Similarly, replica balancing ensures that a copy of the same table will not be d We use Cluster LoadStatistics (CLS) to represent the load balancing of each backend in a cluster. Tablet Scheduler triggers cluster equilibrium based on this statistic. We currently calculate a load Score for each BE as the BE load score by using **disk usage** and **number of copies**. The higher the score, the heavier the load on the BE. -Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. Among them, capacityCoefficient will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the capacityCoefficient value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: +Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. If a valid `backend_load_capacity_coeficient` parameter is configured (value range `0.0`~`1.0`), then `capacityCoefficient = backend_load_capacity_coeficient`. Otherwise, `capacityCoefficient` will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the `capacityCoefficient` value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: `capacityCoefficient = 2 * Disk Utilization - 0.5` Review Comment: The doc introduces `backend_load_capacity_coeficient` but this config key is not referenced anywhere else in the docs (including `docs/admin-manual/config/fe-config.md`), so readers can’t easily discover where/how to set it or verify the exact spelling. Consider explicitly calling it an FE config item and adding a link (or a short note) to the configuration reference. Also, since you state the coefficients “sum is constant to 1”, it would help to explicitly state how `replicaNumCoefficient` is derived when `capacityCoefficient` is fixed (e.g., `replicaNumCoefficient = 1 - capacityCoefficient`). ########## i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -210,7 +210,7 @@ Doris 会自动进行集群内的副本均衡。目前支持两种均衡策略 我们用 ClusterLoadStatistics（CLS）表示一个 cluster 中各个 Backend 的负载均衡情况。TabletScheduler 根据这个统计值，来触发集群均衡。我们当前通过 **磁盘使用率** 和 **副本数量** 两个指标，为每个 BE 计算一个 loadScore，作为 BE 的负载分数。分数越高，表示该 BE 的负载越重。 -磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。其中 capacityCoefficient 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 capacityCoefficient 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： +磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。如果系统配置了有效的 `backend_load_capacity_coeficient` 参数（取值范围 `0.0`~`1.0`），则 `capacityCoefficient = backend_load_capacity_coeficient`。否则，`capacityCoefficient` 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 `capacityCoefficient` 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： `capacityCoefficient= 2 * 磁盘使用率 - 0.5` Review Comment: 这里新增了 `backend_load_capacity_coeficient` 的说明，但该配置项在文档中几乎没有其他引用（包括 FE 配置项参考文档），读者不容易确认具体在哪配置以及该 key 的拼写是否准确。建议明确说明这是 FE 配置项并补充到配置参考或加上链接/提示。另外既然前文强调两个系数“和恒为 1”，当 `capacityCoefficient` 被固定时也建议明确 `replicaNumCoefficient` 的计算方式（例如 `replicaNumCoefficient = 1 - capacityCoefficient`），避免读者疑惑。 ########## versioned_docs/version-3.x/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -206,7 +206,7 @@ Similarly, replica balancing ensures that a copy of the same table will not be d We use Cluster LoadStatistics (CLS) to represent the load balancing of each backend in a cluster. Tablet Scheduler triggers cluster equilibrium based on this statistic. We currently calculate a load Score for each BE as the BE load score by using **disk usage** and **number of copies**. The higher the score, the heavier the load on the BE. -Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. Among them, capacityCoefficient will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the capacityCoefficient value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: +Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. If a valid `backend_load_capacity_coeficient` parameter is configured (value range `0.0`~`1.0`), then `capacityCoefficient = backend_load_capacity_coeficient`. Otherwise, `capacityCoefficient` will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the `capacityCoefficient` value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: `capacityCoefficient = 2 * Disk Utilization - 0.5` Review Comment: The doc introduces `backend_load_capacity_coeficient` but this config key is not referenced anywhere else in the docs (including the FE config reference), so readers can’t easily discover where/how to set it or verify the exact spelling. Consider explicitly calling it an FE config item and adding a link (or a short note) to the configuration reference. Also, since you state the coefficients “sum is constant to 1”, it would help to explicitly state how `replicaNumCoefficient` is derived when `capacityCoefficient` is fixed (e.g., `replicaNumCoefficient = 1 - capacityCoefficient`). ########## i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -210,7 +210,7 @@ Doris 会自动进行集群内的副本均衡。目前支持两种均衡策略 我们用 ClusterLoadStatistics（CLS）表示一个 cluster 中各个 Backend 的负载均衡情况。TabletScheduler 根据这个统计值，来触发集群均衡。我们当前通过 **磁盘使用率** 和 **副本数量** 两个指标，为每个 BE 计算一个 loadScore，作为 BE 的负载分数。分数越高，表示该 BE 的负载越重。 -磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。其中 capacityCoefficient 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 capacityCoefficient 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： +磁盘使用率和副本数量各有一个权重系数，分别为 **capacityCoefficient** 和 **replicaNumCoefficient**，其 **和恒为 1**。如果系统配置了有效的 `backend_load_capacity_coeficient` 参数（取值范围 `0.0`~`1.0`），则 `capacityCoefficient = backend_load_capacity_coeficient`。否则，`capacityCoefficient` 会根据实际磁盘使用率动态调整。当一个 BE 的总体磁盘使用率在 50% 以下，则 `capacityCoefficient` 值为 0.5，如果磁盘使用率在 75%（可通过 FE 配置项 `capacity_used_percent_high_water` 配置）以上，则值为 1。如果使用率介于 50% ~ 75% 之间，则该权重系数平滑增加，公式为： `capacityCoefficient= 2 * 磁盘使用率 - 0.5` Review Comment: 这里新增了 `backend_load_capacity_coeficient` 的说明，但该配置项在文档中几乎没有其他引用（包括 FE 配置项参考文档），读者不容易确认具体在哪配置以及该 key 的拼写是否准确。建议明确说明这是 FE 配置项并补充到配置参考或加上链接/提示。另外既然前文强调两个系数“和恒为 1”，当 `capacityCoefficient` 被固定时也建议明确 `replicaNumCoefficient` 的计算方式（例如 `replicaNumCoefficient = 1 - capacityCoefficient`），避免读者疑惑。 ########## versioned_docs/version-4.x/admin-manual/maint-monitor/tablet-repair-and-balance.md: ########## @@ -206,7 +206,7 @@ Similarly, replica balancing ensures that a copy of the same table will not be d We use Cluster LoadStatistics (CLS) to represent the load balancing of each backend in a cluster. Tablet Scheduler triggers cluster equilibrium based on this statistic. We currently calculate a load Score for each BE as the BE load score by using **disk usage** and **number of copies**. The higher the score, the heavier the load on the BE. -Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. Among them, capacityCoefficient will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the capacityCoefficient value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: +Disk usage and number of copies have a weight factor, which is **capacityCoefficient** and **replicaNumCoefficient**, respectively. The sum of them is **constant to 1**. If a valid `backend_load_capacity_coeficient` parameter is configured (value range `0.0`~`1.0`), then `capacityCoefficient = backend_load_capacity_coeficient`. Otherwise, `capacityCoefficient` will dynamically adjust according to actual disk utilization. When the overall disk utilization of a BE is below 50%, the `capacityCoefficient` value is 0.5, and if the disk utilization is above 75% (configurable through the FE configuration item `capacity_used_percent_high_water`), the value is 1. If the utilization rate is between 50% and 75%, the weight coefficient increases smoothly. The formula is as follows: `capacityCoefficient = 2 * Disk Utilization - 0.5` Review Comment: The doc introduces `backend_load_capacity_coeficient` but this config key is not referenced anywhere else in the docs (including the FE config reference), so readers can’t easily discover where/how to set it or verify the exact spelling. Consider explicitly calling it an FE config item and adding a link (or a short note) to the configuration reference. Also, since you state the coefficients “sum is constant to 1”, it would help to explicitly state how `replicaNumCoefficient` is derived when `capacityCoefficient` is fixed (e.g., `replicaNumCoefficient = 1 - capacityCoefficient`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
