Copilot commented on code in PR #3377:
URL: https://github.com/apache/doris-website/pull/3377#discussion_r2789826157
##########
versioned_docs/version-3.x/table-design/data-partitioning/auto-partitioning.md:
##########
@@ -246,7 +246,7 @@ auto partition by range (date_trunc(k0, 'year'))
)
DISTRIBUTED BY HASH(`k0`) BUCKETS 2
properties(
- "dynamic_partition.enable" = "true",
+ "dynamic_partition.enable" = "false",
"dynamic_partition.prefix" = "p",
"dynamic_partition.start" = "-50",
"dynamic_partition.end" = "0", --- Dynamic Partition No Partition Creation
Review Comment:
The surrounding text says Dynamic Partition is used to reclaim/drop
partitions while Auto Partition creates them, but setting
"dynamic_partition.enable" = "false" disables the dynamic partition feature
entirely (per the dynamic-partitioning docs). With it disabled, the table won’t
be dynamically reclaimed, and the other dynamic_partition.* properties here
become misleading/unused. Either keep dynamic_partition.enable=true (and
document how end=0 affects creation in 3.x), or update the narrative and
properties to reflect that Dynamic Partition lifecycle management is not active
in this example.
##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-3.x/table-design/data-partitioning/auto-partitioning.md:
##########
@@ -243,7 +243,7 @@ auto partition by range (date_trunc(k0, 'year'))
)
DISTRIBUTED BY HASH(`k0`) BUCKETS 2
properties(
- "dynamic_partition.enable" = "true",
+ "dynamic_partition.enable" = "false",
"dynamic_partition.prefix" = "p",
"dynamic_partition.start" = "-50",
"dynamic_partition.end" = "0", --- Dynamic Partition 不创建分区
Review Comment:
文档上下文描述这里通过 Dynamic Partition 来自动回收（删除）分区、由 Auto Partition 负责创建分区；但示例把
"dynamic_partition.enable" 设为 "false" 会直接关闭动态分区功能（dynamic-partitioning 文档中
enable=false 表示禁用），这样就不会再执行动态回收，且其余 dynamic_partition.* 参数也会变得容易误导。建议要么保持
enable=true 并说明 3.x 下 end=0 对“创建”的具体含义，要么同步修改文字/示例参数，明确该例中不启用动态分区生命周期管理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
