freemandealer commented on code in PR #14449:
URL: https://github.com/apache/doris/pull/14449#discussion_r1028781744
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -340,16 +338,19 @@ Status
BetaRowsetWriter::_do_compact_segments(SegCompactionCandidatesSharedPtr s
for (const auto& entry :
std::filesystem::directory_iterator(_context.rowset_dir)) {
fmt::format_to(vlog_buffer, "[{}]", string(entry.path()));
}
- VLOG_DEBUG << "_segcompacted_point:" << _segcompacted_point
+ VLOG_DEBUG << "tablet_id:" << _context.tablet_id << " rowset_id:" <<
_context.rowset_id
+ << "_segcompacted_point:" << _segcompacted_point
<< " _num_segment:" << _num_segment << "
_num_segcompacted:" << _num_segcompacted
<< " list directory:" << fmt::to_string(vlog_buffer);
}
_segcompacted_point += (end - begin + 1);
uint64_t elapsed = GetCurrentTimeMicros() - begin_time;
- LOG(INFO) << "BetaRowsetWriter:" << this << " segcompaction completed.
elapsed time:" << elapsed
- << "us. _segcompacted_point update:" << _segcompacted_point;
+ LOG(INFO) << "segcompaction completed. tablet_id:" << _context.tablet_id
Review Comment:
Thanks for explanation. Now I am a little confused at when I should use
which ... maybe I should benchmark them some day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
