zzzxl1993 commented on code in PR #60701: URL: https://github.com/apache/doris/pull/60701#discussion_r2803987163
########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/union_postings.h: ########## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <algorithm> + +#include "olap/rowset/segment_v2/inverted_index/query_v2/segment_postings.h" + +namespace doris::segment_v2::inverted_index::query_v2 { + +class UnionPostings final : public Postings { +public: + explicit UnionPostings(std::vector<SegmentPostingsPtr> subs) : _subs(std::move(subs)) { + _doc = TERMINATED; + for (auto& sub : _subs) { + _doc = std::min(_doc, sub->doc()); + } + } + + uint32_t advance() override { Review Comment: I considered using a priority queue. Based on our dataset testing, the current linear scan performs well for typical query patterns. The simplicity and cache-friendly nature of linear scan outweigh the theoretical O(log n) advantage of heaps in practice. If profiling shows this becomes a bottleneck in the future, we can optimize with a hybrid approach (e.g., use heap when n > threshold). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
