Lastv25 opened a new pull request, #60779: URL: https://github.com/apache/doris/pull/60779
Removed methods related to catalog retrieval and filtering schemas from the Doris adapter implementation. Use default dbt-adapter functions. ### What problem does this PR solve? Problem Summary: The `dbt docs ...` commands do not work with the dbt-doris adapter due to the error `TypeError: DorisAdapter.get_catalog() takes 2 positional arguments but 3 were given` . The signature of the get_catalog function changed in this commit https://github.com/dbt-labs/dbt-adapters/commit/5d90ff9ab4c9c0eb5137f606b843aec3bf35c6d2 . There is no need to redifine the get_catalog function in the adapter (same with _catalog_filter_table and _catalog_filter_schema functions), the default ones work. Solution: - Remove functions get_catalog, _catalog_filter_schema and _catalog_filter_table from adatpter - Use default functions from the dbt-adapter module ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [X] Unit Test - [] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [X] No. - [ ] Yes. - Does this need documentation? - [X] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
