Copilot commented on code in PR #3172:
URL: https://github.com/apache/doris-website/pull/3172#discussion_r2837398298
##########
versioned_docs/version-4.x/lakehouse/catalogs/iceberg-catalog.mdx:
##########
@@ -2542,6 +2561,51 @@ EXECUTE set_current_snapshot ("ref" = "v1.0");
3. The operation will fail if the specified snapshot ID or reference does not
exist
4. If the current snapshot is already the target snapshot, the operation
returns directly without creating a new snapshot
+### publish_changes
+
+The `publish_changes` operation is used in the WAP (Write-Audit-Publish) mode
to publish a snapshot with the specified `wap.id` as the current table state.
+It locates the snapshot whose `wap.id` matches the given `wap_id` and
cherry-picks it onto the current table, making the staged data visible to all
read operations.
+
+**Syntax:**
+
+```sql
+ALTER TABLE [catalog.][database.]table_name
+EXECUTE publish_changes("wap_id" = "<wap_id>")
+```
+
+**Parameters:**
+
+**Parameters:**
+
Review Comment:
The "Parameters:" heading is duplicated on lines 2576-2578. One of these
duplicate headings should be removed.
```suggestion
```
##########
versioned_docs/version-3.x/lakehouse/catalogs/iceberg-catalog.mdx:
##########
@@ -2542,6 +2561,51 @@ EXECUTE set_current_snapshot ("ref" = "v1.0");
3. The operation will fail if the specified snapshot ID or reference does not
exist
4. If the current snapshot is already the target snapshot, the operation
returns directly without creating a new snapshot
+### publish_changes
+
+The `publish_changes` operation is used in the WAP (Write-Audit-Publish) mode
to publish a snapshot with the specified `wap.id` as the current table state.
+It locates the snapshot whose `wap.id` matches the given `wap_id` and
cherry-picks it onto the current table, making the staged data visible to all
read operations.
+
+**Syntax:**
+
+```sql
+ALTER TABLE [catalog.][database.]table_name
+EXECUTE publish_changes("wap_id" = "<wap_id>")
+```
+
+**Parameters:**
+
+**Parameters:**
+
Review Comment:
The "Parameters:" heading is duplicated on lines 2576-2578. One of these
duplicate headings should be removed.
```suggestion
```
##########
versioned_docs/version-3.x/lakehouse/catalogs/iceberg-catalog.mdx:
##########
@@ -1794,6 +1794,25 @@ For an Iceberg Database, you must first drop all tables
under the database befor
);
```
+ Starting from version 4.1.0, Doris supports specifying sort columns when
creating an Iceberg table. When writing data, the data will be sorted according
to the specified sort columns to achieve better query performance.
+
+ ```sql
+ CREATE TABLE ordered_table (
+ `id` int NULL,
+ `name` text NULL,
+ `score` double NULL,
+ `create_time` datetimev2(6) NULL
+ )
+ ORDER BY (`id` ASC NULLS FIRST, `score` DESC NULLS LAST)
+ PROPERTIES (
Review Comment:
The documentation states this feature is available "Starting from version
4.1.0", but this documentation is being added to the version-3.x documentation
files. If this feature is not actually available in version 3.x, this
documentation should not be added to the version-3.x files. Additionally, the
PR description indicates that 3.x is not checked, which conflicts with the
changes being made to version-3.x files.
##########
docs/lakehouse/catalogs/iceberg-catalog.mdx:
##########
@@ -2542,6 +2561,51 @@ EXECUTE set_current_snapshot ("ref" = "v1.0");
3. The operation will fail if the specified snapshot ID or reference does not
exist
4. If the current snapshot is already the target snapshot, the operation
returns directly without creating a new snapshot
+### publish_changes
+
+The `publish_changes` operation is used in the WAP (Write-Audit-Publish) mode
to publish a snapshot with the specified `wap.id` as the current table state.
+It locates the snapshot whose `wap.id` matches the given `wap_id` and
cherry-picks it onto the current table, making the staged data visible to all
read operations.
+
+**Syntax:**
+
+```sql
+ALTER TABLE [catalog.][database.]table_name
+EXECUTE publish_changes("wap_id" = "<wap_id>")
+```
+
+**Parameters:**
+
+**Parameters:**
+
Review Comment:
The "Parameters:" heading is duplicated on lines 2576-2578. One of these
duplicate headings should be removed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
