xuchenhao commented on code in PR #60583:
URL: https://github.com/apache/doris/pull/60583#discussion_r2845160152
##########
be/src/runtime/query_context.cpp:
##########
@@ -111,11 +111,12 @@ QueryContext::QueryContext(TUniqueId query_id, ExecEnv*
exec_env,
_timeout_second = query_options.execution_timeout;
- bool initialize_context_holder =
- config::enable_file_cache && config::enable_file_cache_query_limit
&&
- query_options.__isset.enable_file_cache &&
query_options.enable_file_cache &&
- query_options.__isset.file_cache_query_limit_percent &&
- query_options.file_cache_query_limit_percent < 100;
+ bool initialize_context_holder = config::enable_file_cache &&
+ config::enable_file_cache_query_limit &&
+ !(query_options.query_type ==
TQueryType::EXTERNAL &&
Review Comment:
内表场景，无论是否开启enable_file_cache_for_olap_table，只要be端开启了file cache，file
cache就会被使用。对于进入disposable队列的情况，也应该为query limit功能生成context_holder。
外表场景，只有开启enable_file_cache_for_external_table的情况下，file cache才会被使用。
因此只有在外表场景且未开启enable_file_cache_for_external_table的情况下，不需要生成context_holder。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
