924060929 commented on code in PR #13879:
URL: https://github.com/apache/doris/pull/13879#discussion_r1030521401
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -510,6 +510,8 @@ private void eliminateFromGroupAndMoveToTargetGroup(Group
fromGroup, Group targe
"TargetGroup should be ancestors of fromGroup, but
fromGroup is root. Maybe a bug");
}
+ moveParentExpressionsReference(fromGroup, targetGroup);
Review Comment:
In the context, `fromGroup` is the group of `LogicalRelation`, and the
`targetGroup` is the group of `LogicalRowPolicy`,
`eliminateFromGroupAndMoveToTargetGroup` will move the
logicalExpression(`LogicalRelation`) to the targetGroup, and the origin
logicalExpression in the targetGroup will be recycle until the
`LogicalRelation`(include `LogicalRowPolicy` and some parent of
`LogicalRelation`).
So I don't think we should `moveParentExpressionsReference(fromGroup,
targetGroup)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
