BiteTheDDDDt opened a new pull request, #61064:
URL: https://github.com/apache/doris/pull/61064
### What problem does this PR solve?
This pull request improves the accuracy and clarity of scanner timing and
profiling in the `ScannerScheduler` implementation. The main changes clarify
the order and logic for updating and recording timing counters, ensuring that
CPU and wait times are measured more precisely during scanner execution and
cleanup.
**Enhancements to scanner timing and profiling:**
* Added detailed comments explaining the correct order for setting and
getting timing counters (`update_wait_worker_timer`, `start_scan_cpu_timer`,
`update_scan_cpu_timer`, `start_wait_worker_timer`) to ensure accurate
measurement of scanner CPU and wait times.
* Refactored the `Defer` cleanup logic to only start the wait worker timer
if the scanner has not failed and has not reached the end-of-stream, preventing
redundant or incorrect counter updates.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
