0AyanamiRei opened a new pull request, #61129:
URL: https://github.com/apache/doris/pull/61129
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When reading S3 files via TVF with` format = "csv_with_names"`, if the first
file in the directory is empty in content (e.g. contains only newlines, so size
> 0), schema inference fails with:
`The first line is empty, can not parse column numbers`
The FE only skips files with size == 0, so files with only
whitespace/newlines pass the check and get sent to BE, where
`_parse_col_names`/`_parse_col_nums `throws an InternalError on the empty first
line, blocking all other valid files from being read.
Solution:
1. BE (`csv_reader.cpp`): When `_parse_col_nums `/ `_parse_col_names `find
the header line is empty, return `Status::EndOfFile` instead of
`Status::InternalError`. This distinguishes "file has no usable content" from a
real error, and the EndOfFile status propagates back to FE via the RPC response
as `TStatusCode.END_OF_FILE`.
2. FE (`ExternalFileTableValuedFunction.java`): `getTableColumns() `now
iterates through all candidate files in fileStatuses. For each file, it sends a
per-file schema inference RPC. If BE returns `END_OF_FILE `(empty content), the
file is logged and skipped, and the next candidate is tried. Iteration
continues until a valid schema is found or all files are exhausted (in which
case a dummy column is returned, matching prior behavior for all-zero-size
directories). `FILE_STREAM `sources are handled separately with the original
single-call path since streams cannot be retried.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
