seawinde commented on code in PR #61145:
URL: https://github.com/apache/doris/pull/61145#discussion_r2909959543
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/exploration/mv/PartitionCompensatorTest.java:
##########
Review Comment:
Since the test doesn't invoke PartitionCompensator.calcInvalidPartitions()
(the actual method containing the bug), it cannot guard against future
regressions. If someone accidentally moves the merge logic back inside the
loop, this test would still pass.
Suggestion: Consider writing the regression test against
calcInvalidPartitions()
directly, with mocked inputs that produce 2+ related table entries
requiring partition compensation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
