zclllyybb commented on code in PR #61196:
URL: https://github.com/apache/doris/pull/61196#discussion_r2918670200
##########
be/src/udf/python/python_env.h:
##########
@@ -145,25 +169,32 @@ class PythonVersionManager {
}
Status init(PythonEnvType env_type, const fs::path& python_root_path,
- const std::string& python_venv_interpreter_paths);
+ const std::string& python_venv_interpreter_paths) {
+ return _holder.init(env_type, python_root_path,
python_venv_interpreter_paths);
+ }
Status get_version(const std::string& runtime_version, PythonVersion*
version) const {
- return _env_scanner->get_version(runtime_version, version);
+ if (!_holder.is_initialized()) {
Review Comment:
如果是为了status返回的话，是不是统一改成抛异常就行了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
