JNSimba opened a new pull request, #61284:
URL: https://github.com/apache/doris/pull/61284
### What problem does this PR solve?
#### Problem
When S3 credentials become invalid (e.g. 403 auth error), the streaming
job neither pauses nor reports an error — it hangs
indefinitely without making progress.
#### Root cause:
S3ObjStorage.globListInternal() catches all exceptions and returns a
GlobListResult with a non-ok Status instead of
rethrowing. S3SourceOffsetProvider.fetchRemoteMeta() called
globListWithLimit() but never checked the returned status.
Since objects was empty, the maxEndFile was never updated,
hasMoreDataToConsume() kept returning false, and the scheduler
retried every 500ms forever without triggering a PAUSE.
The same status check was also missing in getNextOffset(), which would
produce a misleading "No new files found" error
instead of the actual S3 error message.
#### Fix
- In fetchRemoteMeta(): check globListResult status after
globListWithLimit(); throw Exception with the real error message
if not ok, so the upper-level StreamingInsertJob.fetchMeta() catch block
can catch it, set GET_REMOTE_DATA_ERROR, and PAUSE
the job for auto-resume.
- In getNextOffset(): same status check, throw RuntimeException with
accurate error message.
- Add a debug point S3SourceOffsetProvider.fetchRemoteMeta.error to
simulate a failed GlobListResult for testing.
#### Test
Added regression test test_streaming_insert_job_fetch_meta_error: enables
the debug point to inject a failed
GlobListResult, creates a streaming job, waits for it to reach PAUSED
status, and asserts the ErrorMsg contains "Failed to
list S3 files".
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
