wenzhenghu opened a new pull request, #61509:
URL: https://github.com/apache/doris/pull/61509
### What problem does this PR solve?
## Proposed changes
This PR fixes several bugs in the offline tool `meta_tool`, including
coredumps caused by uninitialized ExecEnv components and a dead loop when
loading tablet meta.
1. **Fix coredump in offline commands**:
- For lightweight commands (`show_meta`, `batch_delete_meta`,
`show_segment_footer`, `show_segment_data`): These do not require a full
StorageEngine environment but still rely on basic components like
`TabletSchemaCache`, `TabletColumnObjectPool`, and `MemTracker`. This PR
introduces a lightweight initialization function `init_common_components()` for
them to prevent coredumps caused by null pointer dereferences.
- For engine-level commands (`get_meta`, `load_meta`, `delete_meta`):
These commands initialize a `StorageEngine` and `DataDir` instance to
read/write RocksDB. The PR ensures that they correctly load configurations from
`be.conf` (via `DORIS_HOME`) and also call `init_common_components()` to
guarantee that both the global settings (e.g., memory limits, thread pools) and
the ExecEnv components are properly set up before the engine starts.
2. **Fix dead loop in `load_meta`**:
The `TabletMetaManager::load_json_meta` function previously used
`infile.getline()` in a `while(!infile.eof())` loop. If the file cannot be
opened or an error occurs, the `failbit` is set but not the `eofbit`, causing
an infinite loop. This has been fixed by reading the file content safely using
`std::istreambuf_iterator` and adding an `is_open()` check.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
