VividByteWorker commented on code in PR #61382:
URL: https://github.com/apache/doris/pull/61382#discussion_r2960033059
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -4932,21 +4981,33 @@ public void dropTable(DropMTMVCommand command) throws
DdlException {
throw new DdlException("DropMTMVCommand is null");
}
DropMTMVInfo dropMTMVInfo = command.getDropMTMVInfo();
- dropTable(dropMTMVInfo.getCatalogName(), dropMTMVInfo.getDbName(),
dropMTMVInfo.getTableName(), false,
- true, dropMTMVInfo.isIfExists(), false, true);
+ dropTable(dropMTMVInfo.getCatalogName(), dropMTMVInfo.getDbName(),
dropMTMVInfo.getTableName(), false, true,
+ false, dropMTMVInfo.isIfExists(), false, true);
}
public void dropTable(String catalogName, String dbName, String tableName,
boolean isView, boolean isMtmv,
- boolean ifExists, boolean mustTemporary, boolean
force) throws DdlException {
+ boolean isStream, boolean ifExists, boolean
mustTemporary, boolean force)
Review Comment:
put isStream in the last argument, and add another dropTable function like:
> public void dropTable(String catalogName, String dbName, String tableName,
boolean isView, boolean isMtmv,
> boolean ifExists, boolean mustTemporary, boolean
force) throws DdlException {
this function just call dropTable with isStream set false?
then you will decrease some changes.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/visitor/CommandVisitor.java:
##########
@@ -1521,6 +1532,10 @@ default R
visitAdminRotateTdeRootKeyCommand(AdminRotateTdeRootKeyCommand rotateT
return visitCommand(rotateTdeRootKeyCommand, context);
}
+ default R visitCreateStreamCommand(CreateStreamCommand
createStreamCommand, C context) {
+ return visitCommand(createStreamCommand, context);
+ }
+
Review Comment:
showCreatesCommand missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
