eldenmoon commented on code in PR #61383:
URL: https://github.com/apache/doris/pull/61383#discussion_r2963781152


##########
be/src/exec/common/variant_util.h:
##########
@@ -72,6 +72,18 @@ bool glob_match_re2(const std::string& glob_pattern, const 
std::string& candidat
 using PathToNoneNullValues = std::unordered_map<std::string, int64_t>;
 using PathToDataTypes = std::unordered_map<PathInData, 
std::vector<DataTypePtr>, PathInData::Hash>;
 
+inline bool should_record_variant_path_stats(const TabletColumn& column) {

Review Comment:
   I'll add it next PR



##########
be/src/exec/common/variant_util.cpp:
##########
@@ -848,6 +856,10 @@ Status 
VariantCompactionUtil::aggregate_variant_extended_info(
         if (!column->is_variant_type()) {
             continue;
         }
+        if (column->variant_enable_nested_group()) {

Review Comment:
   I'll add it next PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to