github-actions[bot] commented on code in PR #61555:
URL: https://github.com/apache/doris/pull/61555#discussion_r2964411772
##########
fe/fe-core/src/main/java/org/apache/doris/load/GroupCommitManager.java:
##########
@@ -372,13 +369,26 @@ private Long getCachedBackend(String cluster, long
tableId) {
return null;
}
+ private boolean isBackendAvailable(Backend backend, String cluster) {
+ if (backend == null || !backend.isAlive() ||
backend.isDecommissioned() || !backend.isLoadAvailable()) {
+ return false;
+ }
+ if (!Config.isCloudMode()) {
+ return true;
+ }
Review Comment:
**[Observability issue]** Now that `isBackendAvailable()` rejects backends
based on `isLoadAvailable()` (which checks `isLoadDisabled` and `isShutDown`),
the error messages in `selectBackendForCloudGroupCommitInternal` (line ~303)
and `selectBackendForLocalGroupCommitInternal` (line ~338) should include
`isLoadDisabled` and `isShutDown` fields. Currently they only log `alive`,
`active`, `decommissioned` (and `decommissioning` in the cloud version).
Without this, when all backends are alive but load-disabled, operators will
see a misleading error showing all backends as healthy.
Suggested addition to the error message `map` lambdas:
```java
+ ", loadDisabled=" + be.isLoadDisabled() + ", shutdown=" + be.isShutDown()
```
(Note: `isShutDown()` is private — you may need to add `isLoadAvailable()`
to the message instead, or make `isShutDown` accessible.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
