shuke987 opened a new pull request, #61556:
URL: https://github.com/apache/doris/pull/61556

   ## Summary
   
   - Remove unused `#include "runtime/exec_env.h"` from 7 header files where 
ExecEnv is not referenced at all
   - Replace `#include "runtime/exec_env.h"` with `class ExecEnv;` forward 
declaration in 8 header files that only use `ExecEnv*` (pointer/reference)
   - Move the full `#include "runtime/exec_env.h"` to corresponding `.cpp` 
files where needed to maintain compilation
   
   This reduces the include fan-out of `exec_env.h` (591 lines) across the 
codebase, improving incremental build times when `exec_env.h` or any of its 
transitive dependencies change.
   
   ### Headers with include removed (unused):
   - `pipeline/exec/aggregation_sink_operator.h`
   - `vec/exec/scan/vscanner.h`
   - `vec/sink/load_stream_map_pool.h`
   - `vec/sink/load_stream_stub.h`
   - `vec/sink/writer/vtablet_writer_v2.h`
   - `vec/sink/writer/vtablet_writer.h`
   - `olap/wal/wal_info.h`
   
   ### Headers with forward declaration added:
   - `agent/workload_sched_policy_listener.h`
   - `runtime/group_commit_mgr.h`
   - `olap/wal/wal_manager.h`
   - `olap/wal/wal_table.h`
   - `runtime/query_context.h`
   - `runtime/workload_management/workload_sched_policy_mgr.h`
   - `http/action/compaction_score_action.h`
   - `http/http_handler_with_auth.h`
   
   ## Test plan
   - [ ] Verify full build passes (run buildall)
   - [ ] No functional changes - purely mechanical include cleanup
   - [ ] Each header still compiles standalone (forward declarations provide 
the needed type info for pointer/reference usage)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to