nsivarajan commented on PR #61329:
URL: https://github.com/apache/doris/pull/61329#issuecomment-4103422457
Thanks @gavinchou for the suggestion. Agreed on consistency — the modified
approach removes OSSStorageVault and reuses S3StorageVault. OSS is detected by
endpoint via OSSProperties.guessIsMe() and serialized through
OSSProperties.getObjStoreInfoPB(), which stamps provider=OSS in the proto.
On the BE side, provider=OSS + enable_oss_native_sdk routes to the native
Alibaba OSS SDK (required for ECS instance profile, STS AssumeRole, RRSA/OIDC);
otherwise falls back to the existing AWS SDK S3-compatible path. All other
providers are unchanged.
The Thrift storage policy path (PushStoragePolicyTask) and the flat-map
path (TVF/Export/Load) are also designed to carry provider=OSS through to the
BE so routing is consistent across all paths.
Hope this aligns with the Doris pattern for standardisation and future
provider additions — please let me know if any adjustment is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
