github-actions[bot] commented on code in PR #61614:
URL: https://github.com/apache/doris/pull/61614#discussion_r2975950191
##########
be/src/format/csv/csv_reader.cpp:
##########
@@ -585,6 +585,10 @@ Status CsvReader::_create_file_reader(bool need_schema) {
Status CsvReader::_create_line_reader() {
std::shared_ptr<TextLineReaderContextIf> text_line_reader_ctx;
+ // Hive TextInputFormat defines one record per physical line, so
OpenCSVSerde must not
+ // merge rows across line delimiters even if a quote stays open.
+ const bool allow_multiline_records = !(_range.__isset.table_format_params
&&
+
_range.table_format_params.table_format_type == "hive");
Review Comment:
[medium] Per AGENTS.md, behavioral changes should have regression tests. The
PR states "No need to test (will be run separately by the user)" but this is a
user-visible behavior change to Hive CSV external table queries. A regression
test under `regression-test/` exercising a Hive external table with CSV data
containing quoted newlines would provide end-to-end confidence and prevent
future regressions.
Also consider: should this check be broadened beyond just `"hive"`? For
example, if `table_format_type` is `"transactional_hive"`, should it also use
single-line mode? The current code only checks for `"hive"` but
`file_scanner.cpp` also handles `"transactional_hive"` as a distinct type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
