AntiTopQuark commented on code in PR #61199:
URL: https://github.com/apache/doris/pull/61199#discussion_r2978630281


##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1698,6 +1720,9 @@ protected void 
unprotectedCommitTransaction2PC(TransactionState transactionState
                         transactionState);
                 continue;
             }
+            if (Config.enable_feature_tso && table.enableTso()) {

Review Comment:
   There doesn't seem to be a problem at the moment; the TSO isn't being 
recorded, preventing it from participating in stream usage and incremental 
computation.
   



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -595,6 +597,9 @@ public class Env {
     private final Map<String, Supplier<MasterDaemon>> configtoThreads = 
ImmutableMap
             .of("dynamic_partition_check_interval_seconds", 
this::getDynamicPartitionScheduler);
 
+    private AtomicLong windowEndTSO = new AtomicLong(0);

Review Comment:
   done~



##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3353,6 +3353,58 @@ public static int metaServiceRpcRetryTimes() {
     @ConfField(mutable = true, masterOnly = true)
     public static long mow_get_ms_lock_retry_backoff_interval = 80;
 
+    @ConfField(mutable = true, masterOnly = true, description = {
+            "是否启用TSO功能",
+            "Whether to enable TSO"}, varType = 
VariableAnnotation.EXPERIMENTAL)
+    public static boolean enable_feature_tso = false;
+
+    @ConfField(mutable = false, masterOnly = true, description = {
+            "TSO服务的更新间隔,单位为毫秒。默认值为50,表示TSO服务每隔50毫秒执行一次时间戳更新检查。",
+            "TSO service update interval in milliseconds. Default is 50, which 
means the TSO service "
+                    + "will perform timestamp update checks every 50 
milliseconds."})
+    public static int tso_service_update_interval_ms = 50;
+
+    @ConfField(mutable = true, masterOnly = true, description = {
+            "TSO服务最大重试次数,默认值为3,表示TSO服务最多重试3次更新全局时间戳。",
+            "TSO service max retry count. Default is 3, which means the TSO 
service will retry 3 times"
+                    + "to update the global timestamp."})
+    public static int max_update_tso_retry_count = 3;
+
+    @ConfField(mutable = true, masterOnly = true, description = {
+            "TSO获取最大重试次数,默认值为10,表示TSO服务最多重试10次生成TSO。",
+            "TSO get max retry count. Default is 10, which means the TSO 
service will retry 10 times"
+                    + "to generate TSO."})
+    public static int max_get_tso_retry_count = 10;

Review Comment:
   done~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to