github-actions[bot] commented on PR #61842:
URL: https://github.com/apache/doris/pull/61842#issuecomment-4153154772
## Code Review Summary
**PR #61842**: [test](regression) merge unique tests of nereids_p0 into
query_p0
### Scope
This is a **test-only PR** — all 1185 changed files are within
`regression-test/`. No production code (BE, FE, cloud) is modified. The PR
consolidates regression tests from `nereids_p0` into `query_p0`, eliminating
duplication now that Nereids is the default planner.
### Part 1.3 Critical Checkpoints
| Checkpoint | Conclusion |
|---|---|
| **Goal accomplished?** | Yes. The PR merges unique test content from
`nereids_p0` into `query_p0` and removes the now-redundant `nereids_p0` copies.
Files that existed only in `nereids_p0` are renamed/moved; files with unique
test cases in both locations have the nereids-specific cases merged into the
`query_p0` version. |
| **Modification minimal and focused?** | Yes. Changes are purely test
reorganization — no unrelated modifications. |
| **Concurrency?** | N/A — no production code, no concurrency concerns. |
| **Lifecycle management?** | N/A — no production code. |
| **Configuration items?** | N/A — no config changes. Removal of `set
enable_nereids_planner=true` and `set
enable_fallback_to_original_planner=false` is correct since Nereids is now the
default. |
| **Incompatible changes?** | N/A — no production code. |
| **Parallel code paths?** | N/A — test consolidation only. |
| **Special conditional checks?** | Some tests add `sql "set
disable_nereids_rules='PRUNE_EMPTY_PARTITION'"` which is appropriate for tests
that need to verify behavior without that optimization. |
| **Test coverage?** | The PR preserves all unique test cases from both
directories. No test coverage is lost. |
| **Observability?** | N/A — test-only. |
| **Transaction/persistence?** | N/A. |
| **Data writes?** | N/A. |
| **FE-BE variables?** | N/A. |
| **Performance?** | N/A. |
| **Other issues?** | Verified that no `nereids_test_query_db` or
`nereids_p0` references remain in the `query_p0` directory — all database
references have been correctly updated. |
### Part 4: Test Standards Compliance
| Standard | Status |
|---|---|
| `order_qt_` or explicit `ORDER BY` | ✅ Existing patterns preserved |
| Expected errors use `test { sql ...; exception ... }` | ✅ Correct pattern
used |
| Tables dropped before use | ✅ Generally followed |
| Table names hardcoded | ✅ Consistent with existing code |
| `.out` files auto-generated | ✅ New `.out` file has auto-generated header |
### Conclusion
**No issues found.** This is a clean test consolidation PR that correctly
merges unique test content from `nereids_p0` into `query_p0`, removes obsolete
planner settings, and updates database references. All test standards are
followed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
