seawinde opened a new pull request, #61898:
URL: https://github.com/apache/doris/pull/61898

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Problem Summary:
   After upgrading from 4.0.2 to 4.0.4, executing `SHOW CREATE MATERIALIZED 
VIEW` throws NullPointerException because `MTMV.getSessionVariables()` returns 
null for materialized views created before the `sessionVariables` field was 
introduced.
   
   The `sessionVariables` field (annotated with `@SerializedName("sv")`) was 
added after 4.0.2. MTMVs created in 4.0.2 do not have this field persisted, so 
after upgrade it deserializes as null. The code in 
`ShowCreateMTMVInfo.getShowResultSet()` called 
`mtmv.getSessionVariables().toString()` without null protection.
   
   Fix: Add null check - when sessionVariables is null, display empty map `{}`.
   
   ### Release note
   
   Fix NPE when executing SHOW CREATE MATERIALIZED VIEW for materialized views 
created before the sessionVariables feature was introduced (e.g. upgrade from 
4.0.2 to 4.0.4).
   
   ### Check List (For Author)
   
   - Test: Unit Test
   - Behavior changed: No
   - Does this need documentation: No
   
   ### What problem does this PR solve?
   
   Issue Number: #58031 
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to