github-actions[bot] commented on code in PR #61918: URL: https://github.com/apache/doris/pull/61918#discussion_r3032231951
########## fe/fe-core/src/main/java/org/apache/doris/analysis/ExprToExprNameVisitor.java: ########## @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.common.NameFormatUtils; + +/** + * Visitor that computes the "expr name" for an {@link Expr} tree. + * + * <p>The expr name is a short, normalized identifier used for column labels + * and other metadata — it is <b>not</b> a full SQL representation. + * + * <ul> + * <li>{@link SlotRef} → raw column name</li> + * <li>{@link FunctionCallExpr} → normalized function name</li> + * <li>{@link ColumnRefExpr} → normalized column name</li> + * <li>{@link LiteralExpr} (all subtypes) → {@code "literal"}</li> + * <li>Everything else → normalized simple class name</li> + * </ul> + */ +public class ExprToExprNameVisitor extends ExprVisitor<String, Void> { Review Comment: This visitor replaces the removed `getExprName()` overrides, but I don't see any focused regression coverage proving it preserves the old special cases (`SlotRef`, `VirtualSlotRef`, `ColumnRefExpr`, `FunctionCallExpr`, `LiteralExpr`). That output now feeds Iceberg/Paimon/MaxCompute name translation, so a mismatch here silently changes pushdown/partition behavior. Please add a small unit test that exercises those expression types directly. ########## fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnToThrift.java: ########## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.catalog; + +import org.apache.doris.common.Config; +import org.apache.doris.thrift.TAggregationType; +import org.apache.doris.thrift.TColumn; +import org.apache.doris.thrift.TColumnType; +import org.apache.doris.thrift.TPatternType; + +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +public class ColumnToThrift { + + public static void setIndexFlag(TColumn tColumn, OlapTable olapTable) { + Set<String> bfColumns = olapTable.getCopiedBfColumns(); + if (bfColumns != null && bfColumns.contains(tColumn.getColumnName())) { + tColumn.setIsBloomFilterColumn(true); + } + } + + public static TColumn toThrift(Column column) { + TColumn tColumn = new TColumn(); Review Comment: This helper now sits on several FE->BE and cloud schema paths (`CreateReplicaTask`, `AlterReplicaTask`, sinks, scan nodes, `ColumnToProtobuf`'s sibling extraction, etc.), but this PR does not add any serializer parity coverage. Given the amount of moved logic here, please add focused tests that build representative `Column`s and assert the produced `TColumn`/`ColumnPB` fields for shadow names, default values, agg-state children, and variant pattern metadata. Right now the refactor is only compile-verified, so a drift here will show up as a runtime schema/create-tablet failure instead of a unit-test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
