Mryange opened a new pull request, #62242:
URL: https://github.com/apache/doris/pull/62242

   ### What problem does this PR solve?
   
   Problem Summary:
   
   Array functions (e.g. `array_join`, `array_element`) contain repetitive 
boilerplate for unpacking `ColumnArray`'s Const/Nullable wrappers, extracting 
offsets, nested null maps, and flat data pointers. This makes the code verbose 
and error-prone.
   
   This PR introduces `ColumnArrayView<PType>` — a lightweight, read-only view 
over `Array<scalar>` columns that automatically handles Const / Nullable 
unwrapping and provides a clean index-based access API via `operator[]`, 
returning `ArrayDataView` with `size()`, `is_null_at()`, and `value_at()` 
methods.
   
   As a first adoption, `function_array_join.h` is refactored to use 
`ColumnArrayView<TYPE_STRING>`, removing the dependency on 
`extract_column_array_info` / `ColumnArrayExecutionData` and simplifying the 
inner loop from raw flat-index manipulation to per-row `ArrayDataView` access.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to