Mryange opened a new pull request, #62262:
URL: https://github.com/apache/doris/pull/62262
### What problem does this PR solve?
`function_string.h` was a 5393-line monolithic header containing ~40
function class implementations with heavy dependencies (`pugixml`, ICU,
Boost.Locale, digest libs, etc.). Every translation unit including it pulled in
all dependencies, causing slow compilation and unnecessary rebuilds.
This PR splits it into 9 domain-specific files. 6 files with no external
consumers are converted to standalone `.cpp` with their own registration
functions. 3 files with external consumers remain as `.h`.
**Converted to .cpp (6 files):**
- `function_string_basic.cpp` — Strcmp, Substring, Left, Right, NullOrEmpty
- `function_string_mask.cpp` — Mask, MaskPartial
- `function_string_search.cpp` — LocatePos, SplitPart, SubstringIndex,
SplitByString, CountSubString
- `function_string_digest.cpp` — SM3, MD5, SHA1, SHA2
- `function_string_url.cpp` — ExtractURLParameter, ParseUrl, UrlDecode,
UrlEncode
- `function_string_misc.cpp` — AutoPartitionName, RandomBytes, ConvertTo,
IntToChar, NgramSearch, Translate, XPathString, MakeSet, ExportSet, Crc32,
UnicodeNormalize
**Kept as .h (3 files):**
- `function_string_concat.h` — used by `column_string_test.cpp`
- `function_string_format.h` — used by `function_money_format_test.cpp`
- `function_string_replace.h` — used by `function_reverse.h`,
`function_sub_replace_test.cpp`
**Other changes:**
- `function_string.cpp` — removed original header include, calls 6
sub-registration functions via extern declarations
- Removed unnecessary `function_string.h` includes from
`partition_transformers.h` and `function_split_by_regexp.cpp`
- Updated test files to include specific sub-headers
- Fixed missing `block.h` include in `function_array_reverse.h`
- Fixed pre-existing missing `vexpr_context.h` include in
`viceberg_merge_sink.cpp`
The original `function_string.h` is deleted.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
