morrySnow commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1042270725


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? 
extends Plan> topN, PlanTra
         return mergeFragment;
     }
 
+    private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {

Review Comment:
   i think, we do not need to re-generate orderKey list. just mod 
generateTupleDesc to generate slot for non-SlotReference key is enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to