github-actions[bot] commented on code in PR #62290:
URL: https://github.com/apache/doris/pull/62290#discussion_r3057153001
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -698,10 +685,9 @@ private boolean
isEnableCooldownReplicaAffinity(ConnectContext connectContext) {
private void computePartitionInfo() throws AnalysisException {
long start = System.currentTimeMillis();
// Step1: compute partition ids
- PartitionNamesInfo partitionNames =
desc.getRef().getPartitionNamesInfo();
PartitionInfo partitionInfo = olapTable.getPartitionInfo();
if (partitionInfo.getType() == PartitionType.RANGE ||
partitionInfo.getType() == PartitionType.LIST) {
Review Comment:
This drops the only FE side restriction that preserves explicitly specified
partitions when OlapScanNode recomputes partition ids. Nereids still builds
LogicalOlapScan with selectedPartitionIds equal to specifiedPartitions for
queries like SELECT * FROM t PARTITION p1, and lazyEvaluateRangeLocations later
calls computePartitionInfo. After this change, that method always starts from
all partitions, so the manual partition subset is lost on this path. Please
keep the explicit partition filter here, or preserve the preselected partition
set when recomputing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
