github-actions[bot] commented on code in PR #62201:
URL: https://github.com/apache/doris/pull/62201#discussion_r3067488389
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DateTimeV2Type.java:
##########
@@ -150,7 +150,7 @@ public boolean equals(Object o) {
@Override
public boolean acceptsType(DataType other) {
- return other instanceof DateTimeV2Type;
+ return other.equals(this);
}
Review Comment:
This changes a shared coercion primitive for every `DateTimeV2` signature
match, but the added tests only exercise `SimplifyConditionalFunction` plus the
`CreateMap` symptom path. Please add a direct regression for this contract
change itself, or at least cover one other unaffected
`DateTimeV2Type.WILDCARD`/`MAX` consumer (for example `field(...)` or a date
arithmetic function), otherwise another caller can silently regress without
being caught by this PR's test set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
