Gabriel39 commented on code in PR #14923:
URL: https://github.com/apache/doris/pull/14923#discussion_r1042948221
##########
be/src/vec/exec/vassert_num_rows_node.cpp:
##########
@@ -39,20 +37,20 @@ VAssertNumRowsNode::VAssertNumRowsNode(ObjectPool* pool,
const TPlanNode& tnode,
}
Status VAssertNumRowsNode::open(RuntimeState* state) {
- START_AND_SCOPE_SPAN(state->get_tracer(), span,
"VAssertNumRowsNode::open");
- SCOPED_TIMER(_runtime_profile->total_time_counter());
- RETURN_IF_ERROR(ExecNode::open(state));
+ RETURN_IF_ERROR(alloc_resource(state));
// ISSUE-3435
RETURN_IF_ERROR(child(0)->open(state));
return Status::OK();
}
-Status VAssertNumRowsNode::get_next(RuntimeState* state, Block* block, bool*
eos) {
- INIT_AND_SCOPE_GET_NEXT_SPAN(state->get_tracer(), _get_next_span,
- "VAssertNumRowsNode::get_next");
+Status VAssertNumRowsNode::alloc_resource(RuntimeState* state) {
Review Comment:
Seems this is useless. Can we use ExecNode::alloc_resource ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
