github-actions[bot] commented on code in PR #15009:
URL: https://github.com/apache/doris/pull/15009#discussion_r1045449045
##########
be/src/runtime/plan_fragment_executor.cpp:
##########
@@ -338,12 +337,8 @@
return Status::OK();
Review Comment:
warning: expected unqualified-id [clang-diagnostic-error]
```cpp
return Status::OK();
^
```
##########
be/src/runtime/plan_fragment_executor.cpp:
##########
@@ -309,11 +307,12 @@ Status PlanFragmentExecutor::open_vectorized_internal() {
_collect_query_statistics();
}
- auto st = _sink->send(runtime_state(), block);
- if (st.is<END_OF_FILE>()) {
- break;
+ auto st = _sink->send(runtime_state(), block);
+ if (st.is<END_OF_FILE>()) {
+ break;
+ }
+ RETURN_IF_ERROR(st);
}
- RETURN_IF_ERROR(st);
}
}
Review Comment:
warning: non-void function does not return a value in all control paths
[clang-diagnostic-return-type]
```cpp
}
^
```
##########
be/src/runtime/plan_fragment_executor.cpp:
##########
@@ -338,12 +337,8 @@
return Status::OK();
}
-Status
PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block) {
- if (_done) {
- *block = nullptr;
- return Status::OK();
- }
-
+// Only *eos == true, maybe _block->rows() == 0. else _block->rows() always
have rows
+Status
PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block, bool* eos) {
Review Comment:
warning: use of undeclared identifier 'PlanFragmentExecutor'; did you mean
'doris::PlanFragmentExecutor'? [clang-diagnostic-error]
```suggestion
Status
doris::PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block, bool* eos) {
```
**be/src/runtime/runtime_filter_mgr.h:42:** 'doris::PlanFragmentExecutor'
declared here
```cpp
class PlanFragmentExecutor;
^
```
##########
be/src/runtime/plan_fragment_executor.cpp:
##########
@@ -338,12 +337,8 @@
return Status::OK();
}
-Status
PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block) {
- if (_done) {
- *block = nullptr;
- return Status::OK();
- }
-
+// Only *eos == true, maybe _block->rows() == 0. else _block->rows() always
have rows
+Status
PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block, bool* eos) {
Review Comment:
warning: unknown type name 'Status'; did you mean 'doris::Status'?
[clang-diagnostic-error]
```suggestion
doris::Status
PlanFragmentExecutor::get_vectorized_internal(::doris::vectorized::Block**
block, bool* eos) {
```
**be/src/exec/es/es_scan_reader.h:28:** 'doris::Status' declared here
```cpp
class Status;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
