yiguolei commented on code in PR #60567:
URL: https://github.com/apache/doris/pull/60567#discussion_r3123594942
##########
be/src/runtime/query_context.h:
##########
@@ -307,6 +310,13 @@ class QueryContext : public
std::enable_shared_from_this<QueryContext> {
Status reset_global_rf(const google::protobuf::RepeatedField<int32_t>&
filter_ids);
private:
+ struct TaskCounts {
+ int total = 0;
+ int finished = 0;
+ };
+ TaskCounts _finished_task_counts;
Review Comment:
不要用lock，lock 经常需要lock，释放，还需要考虑作用域。
这里直接使用2个atomic 变量就好了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
