HappenLee commented on code in PR #62222:
URL: https://github.com/apache/doris/pull/62222#discussion_r3186394787


##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -2687,14 +2687,19 @@ Status SegmentIterator::_next_batch_internal(Block* 
block) {
     // If the row bitmap size is smaller than nrows_read_limit, there's no 
need to reserve that many column rows.
     uint32_t nrows_read_limit =
             std::min(cast_set<uint32_t>(_row_bitmap.cardinality()), 
_opts.block_row_max);
-    if (_can_opt_topn_reads()) {
-        nrows_read_limit = std::min(static_cast<uint32_t>(_opts.topn_limit), 
nrows_read_limit);
+    if (_can_opt_limit_reads()) {

Review Comment:
   segment的情况
   1. 没有conjunct和predicate
   2. 有conjunct和predicate 
   dup表: select  a,b,c from tbl where a > 10 limit 100; 
   4096 a  -》 500 > b,c limit-》100



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to