github-actions[bot] commented on code in PR #62994:
URL: https://github.com/apache/doris/pull/62994#discussion_r3188247187
##########
be/src/core/block/block.cpp:
##########
@@ -353,25 +350,6 @@ size_t Block::bytes() const {
return res;
}
-std::string Block::columns_bytes() const {
Review Comment:
The implementation is removed, but `be/src/core/block/block.h` still
declares `std::string columns_bytes() const;`. That leaves a public `Block` API
with no definition, so any caller that includes the header and calls this
method will fail at link time. Please remove the declaration as well, or keep
the definition if the API should remain available.
##########
be/src/core/binary_cast.hpp:
##########
@@ -27,46 +27,12 @@
#include "core/value/vdatetime_value.h"
namespace doris {
-union TypeConverter {
Review Comment:
Removing these union helpers breaks the benchmark target.
`be/benchmark/benchmark_main.cpp` still includes `binary_cast_benchmark.hpp`,
and that header's `old_binary_cast()` still references `TypeConverter`,
`VecDateTimeInt64Union`, `DateV2UInt32Union`, `DateTimeV2UInt64Union`, and
`DecimalInt128Union`. Since `be/CMakeLists.txt` builds this file when
`BUILD_BENCHMARK` is enabled, `-DBUILD_BENCHMARK=ON` will no longer compile.
Please either update/remove the benchmark's old implementation or keep local
benchmark-only definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
