Mryange opened a new pull request, #63076:
URL: https://github.com/apache/doris/pull/63076
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
The uniform function takes three arguments: min, max, and seed. Only the
first two (min, max) are truly "always constant" — the seed column should be
treated as a
regular column, not a constant. Without overriding
get_arguments_that_are_always_constant(), when a user passes a constant value
as the third argument (seed), the
default framework logic treats it as a constant column, leading to
incorrect results.
Root cause: the base class default
get_arguments_that_are_always_constant() does not distinguish between the seed
argument and the min/max arguments, so a constant
seed would be folded by the constant-handling path rather than being
treated as a per-row value.
Fix:
- Override get_arguments_that_are_always_constant() to return {0, 1},
explicitly marking only min and max as always-constant arguments.
- Refactor seed column access to use ColumnView<TYPE_BIGINT> for safer and
more idiomatic typed column iteration.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
